Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rustls to 0.22.1 #1056

Merged
merged 1 commit into from
Dec 14, 2023
Merged

update rustls to 0.22.1 #1056

merged 1 commit into from
Dec 14, 2023

Conversation

Keksoj
Copy link
Contributor

@Keksoj Keksoj commented Dec 14, 2023

no regression in performance:

rustls 0.21

tls-perf -l 200 -n 10000 --sni localhost --tls 1.3 127.0.0.1 8443

 TOTAL:           SECONDS 21; HANDSHAKES 10000
 HANDSHAKES/sec:  MAX 537; AVG 472; 95P 449; MIN 39
 LATENCY (ms):    MIN 30.6086; AVG 381.154; 95P 694.265; MAX 756.129

rustls 0.22.1 :

ls-perf -l 200 -n 10000 --sni localhost --tls 1.3 127.0.0.1 8443

 TOTAL:           SECONDS 19; HANDSHAKES 10000
 HANDSHAKES/sec:  MAX 554; AVG 521; 95P 482; MIN 482
 LATENCY (ms):    MIN 34.738; AVG 370.147; 95P 673.783; MAX 756.83

This update could not be done in the e2e tests because hyper-rustls has not updated its dependency to rustls 0.22. We have to monitor this PR on hyper-rustls

@Keksoj Keksoj added the tls all regarding certificates and handshakes label Dec 14, 2023
@Keksoj Keksoj added this to the v0.16.0 milestone Dec 14, 2023
@Keksoj Keksoj self-assigned this Dec 14, 2023
@FlorentinDUBOIS FlorentinDUBOIS merged commit 9d5788c into main Dec 14, 2023
13 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the update-rustls-to-0.22 branch December 14, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinDUBOIS FlorentinDUBOIS FlorentinDUBOIS approved these changes

@Wonshtrum Wonshtrum Awaiting requested review from Wonshtrum Wonshtrum is a code owner

Assignees

@Keksoj Keksoj

Labels
tls all regarding certificates and handshakes
Projects
Roadmap
Status: Done
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Keksoj @FlorentinDUBOIS